Remove _source_index from MultiIndex #9191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9191 +/- ##
===============================================
Coverage ? 10.84%
===============================================
Files ? 115
Lines ? 18761
Branches ? 0
===============================================
Hits ? 2035
Misses ? 16726
Partials ? 0 Continue to review full report at Codecov.
|
galipremsagar
requested changes
Sep 10, 2021
thomcom
reviewed
Sep 14, 2021
thomcom
approved these changes
Sep 14, 2021
galipremsagar
approved these changes
Sep 15, 2021
galipremsagar
added
5 - Ready to Merge
|
rerun tests |
|
@gpucibot merge |
skirui-source
approved these changes
Sep 15, 2021
|
rerun tests |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
This PR is a follow-up to #9191 to further simplify the MultiIndex class. It removes various unused functions, inlines and simplifies a number of other single-use internal functions, and moves more methods to Frame that can be shared. It also makes numerous other miscellaneous improvements to the code in MultiIndex to simplify further rewrites. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Marlene (https://github.com/marlenezw) - H. Thomson Comer (https://github.com/thomcom) - GALI PREM SAGAR (https://github.com/galipremsagar) - Ashwin Srinath (https://github.com/shwina) URL: #9243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in a sequence refactoring the
MultiIndexclass, which is currently in a halfway state of making use of some facilities common to other Frames without using them consistently. This PR removes the internal_source_dataparameter, which creates a thinDataFramewrapper around aMultiIndexto provide access to those methods. SinceMultiIndexis now clearly defined as aFrame, this PR moves us towards a much simpler and more uniform design where we use inheritedFramemethods directly. This approach is significantly easier to maintain than treating aMultiIndexas being "backed" by aDataFrame. This approach also comes with various performance benefits. While relatively cheap, the internal conversion of aMultiIndexto aDataFrameis not free, and in cases where we need to return a modifiedMultiIndexthe conversion back from aDataFrameis significantly more complex. Moreover, in a number of cases we were using less efficient methods than those we could use directly on theMultiIndex.