Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary call to device_uvector::release() #9237

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Remove unnecessary call to device_uvector::release() #9237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cpp/include/cudf/lists/detail/gather.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,6 @@ gather_data make_gather_data(cudf::lists_column_view const& source_column,
return src_offsets[index] - shift;
});

// now that we are done using the gather_map, we can release the underlying prev_base_offsets.
// doing this prevents this (potentially large) memory buffer from sitting around unused as the
// recursion continues.
prev_base_offsets.release();

// Retrieve size of the resulting gather map for level N+1 (the last offset)
size_type child_gather_map_size =
cudf::detail::get_value<size_type>(dst_offsets_c->view(), output_count, stream);
Expand Down