Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary call to device_uvector::release() #9237

Merged

Conversation

harrism
Copy link
Member

@harrism harrism commented Sep 15, 2021

There was an unneeded call to device_uvector::release() that did not use the return value. rapidsai/rmm#857 marks that function [[nodiscard]], so removing this allows libcudf to compile after the RMM PR is merged.

The release() is unnecessary because prev_base_offsets is passed by rvalue reference and therefore will be freed when the function exits (the uvector in the calling context it has been moved-from).

@harrism harrism requested a review from a team as a code owner September 15, 2021 23:09
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 15, 2021
@harrism harrism added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 15, 2021
@harrism harrism self-assigned this Sep 15, 2021
@harrism harrism requested a review from nvdbaranec September 15, 2021 23:10
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@015f15c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c152b6a differs from pull request most recent head fef4ac5. Consider uploading reports for the commit fef4ac5 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9237   +/-   ##
===============================================
  Coverage                ?   10.84%           
===============================================
  Files                   ?      115           
  Lines                   ?    18761           
  Branches                ?        0           
===============================================
  Hits                    ?     2035           
  Misses                  ?    16726           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015f15c...fef4ac5. Read the comment docs.

@harrism
Copy link
Member Author

harrism commented Sep 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 40a3b03 into rapidsai:branch-21.10 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants