Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add min and max bounds for random dataframe generator numeric types #9211

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[REVIEW] Add min and max bounds for random dataframe generator numeric types #9211

merged 2 commits into from
Sep 13, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR provides the ability to pass in min and max bounds incase of numeric dtypes to the randon dataframe generator API.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 10, 2021
@galipremsagar galipremsagar self-assigned this Sep 10, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner September 10, 2021 00:58
@galipremsagar galipremsagar mentioned this pull request Sep 10, 2021
Merged
isVoid
isVoid approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to my branch that this works! Just one small comment - feel free to ignore at your discretion. Thanks for putting it together so quickly!

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 10, 2021
@isVoid
Copy link
Contributor

isVoid commented Sep 10, 2021

rerun tests

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Sep 13, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@28a6292). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3ac0a24 differs from pull request most recent head d56d353. Consider uploading reports for the commit d56d353 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9211   +/-   ##
===============================================
  Coverage                ?   10.82%           
===============================================
  Files                   ?      115           
  Lines                   ?    19163           
  Branches                ?        0           
===============================================
  Hits                    ?     2074           
  Misses                  ?    17089           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a6292...d56d353. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 90ed9d0 into rapidsai:branch-21.10 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @isVoid