Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python bindings to fixed-size window and groupby rolling.var, rolling.std #9097

Merged
merged 59 commits into from
Sep 15, 2021
Merged

Add python bindings to fixed-size window and groupby rolling.var, rolling.std #9097

merged 59 commits into from
Sep 15, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Aug 23, 2021 •
edited
Loading

Closes #8695
Closes #8696

This PR creates bindings for rolling aggregations for variance and standard deviations. Unlike pandas, the underlying implementation from libcudf computes each window independently from other windows.

isVoid and others added 30 commits July 20, 2021 19:12
@isVoid
initial
7cc6630
@isVoid
Compiles
6f64691
@isVoid
style
2ab88fe
@isVoid
clean up
2f63568
@isVoid
clean up
16cb7a8
@isVoid
header cleanup
ddd59f0
@isVoid
.
bcd00f0
@isVoid
More cleanup
da8b755
@isVoid
revert ptx changes
3ff0d8d
@isVoid
Static tests
fc00d8f
@isVoid
undo python changes
1259df6
@isVoid
.
3539e1b
@isVoid
docs
07aa54d
@isVoid
Merge branch 'rolling_std' into rolling_agg_python
1cc6fbe
@isVoid
initial
d250115
@isVoid
Merge branch 'branch-21.10' of https://github.com/rapidsai/cudf into …
d2a6407 
…rolling_std
@isVoid
remove count==1 restriction
885d66e
@isVoid
add ddof tests
68ab4ae
@isVoid
docfix
1e1c8cd
@isVoid
Merge branch 'rolling_std' into rolling_agg_python
e66badd
@isVoid
fixed_point fix
1288a56
@isVoid
docs
3a9e589
@isVoid
docfix
490539c
@isVoid
Merge branch 'rolling_std' into rolling_agg_python
b73abab
@isVoid
docfix
394f0f0
@isVoid
Merge branch 'rolling_std' into rolling_agg_python
f01a222
@isVoid
initial testings
fe2b4f4
@isVoid
remove thrust::reduce
bc0920b
@isVoid
.
934f104
@isVoid @harrism
Update cpp/src/rolling/rolling_detail.cuh
b215199 
Co-authored-by: Mark Harris <[email protected]>
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Sep 8, 2021
@isVoid isVoid self-assigned this Sep 8, 2021
@isVoid isVoid added non-breaking Non-breaking change feature request New feature or request 3 - Ready for Review Ready for review by team labels Sep 8, 2021
@isVoid isVoid changed the title Add python bindings to rolling.var, rolling.std Add python bindings to fixed-sized and groupby rolling.var, rolling.std Sep 8, 2021
@isVoid isVoid changed the title Add python bindings to fixed-sized and groupby rolling.var, rolling.std Add python bindings to fixed-size window and groupby rolling.var, rolling.std Sep 8, 2021
@isVoid isVoid marked this pull request as ready for review September 8, 2021 22:14
@isVoid isVoid requested a review from a team as a code owner September 8, 2021 22:14
@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@9b532ab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9097   +/-   ##
===============================================
  Coverage                ?   10.81%           
===============================================
  Files                   ?      115           
  Lines                   ?    19173           
  Branches                ?        0           
===============================================
  Hits                    ?     2074           
  Misses                  ?    17099           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b532ab...0f6c359. Read the comment docs.

vyasr
vyasr approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request for more comments, otherwise the bindings look fine. I would like to investigate ways to reduce the amount of code duplication in the aggregations, but that's out of scope for this PR.

python/cudf/cudf/tests/test_rolling.py Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor

rerun tests

@jrhemstad
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a855660 into rapidsai:branch-21.10 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar left review comments

@vyasr vyasr vyasr approved these changes

@skirui-source skirui-source skirui-source approved these changes

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Groupby rolling standard deviation [FEA] Rolling standard deviation
5 participants
@isVoid @galipremsagar @jrhemstad @vyasr @skirui-source