Remove zlib from libcudf public CMake dependencies #9204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
|
@kkraus14 Followup from your comment about |
kkraus14
approved these changes
Sep 9, 2021
robertmaynard
force-pushed
the
bug/remove_zlib_from_public_deps
branch
from
6aa471d to
7da6c3a
Compare
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9204 +/- ##
===============================================
Coverage ? 10.85%
===============================================
Files ? 115
Lines ? 19158
Branches ? 0
===============================================
Hits ? 2080
Misses ? 17078
Partials ? 0 Continue to review full report at Codecov.
|
|
rerun tests |
harrism
approved these changes
Sep 17, 2021
kkraus14
reviewed
Sep 17, 2021
kkraus14
approved these changes
Sep 17, 2021
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcudf doesn't expose zlib in the public facing API, and therefore C++ consumers don't need to also link / include zlib.