Skip to content

Commit

Permalink
Remove zlib from libcudf public CMake dependencies (#9204)
Browse files Browse the repository at this point in the history
libcudf doesn't expose zlib in the public facing API, and therefore C++ consumers don't need to also link / include zlib.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)
  - Keith Kraus (https://github.com/kkraus14)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - Mark Harris (https://github.com/harrism)

URL: #9204
  • Loading branch information
robertmaynard authored Sep 17, 2021
1 parent e04fe79 commit 91d412b
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,8 @@ include(cmake/Modules/ConfigureCUDA.cmake) # set other CUDA compilation flags
# - dependencies ----------------------------------------------------------------------------------

# find zlib
rapids_find_package(ZLIB REQUIRED
BUILD_EXPORT_SET cudf-exports
INSTALL_EXPORT_SET cudf-exports)
rapids_find_package(ZLIB REQUIRED)

# find Threads (needed by cudftestutil)
rapids_find_package(Threads REQUIRED
BUILD_EXPORT_SET cudf-exports
Expand Down Expand Up @@ -506,11 +505,11 @@ add_dependencies(cudf jitify_preprocess_run)

# Specify the target module library dependencies
target_link_libraries(cudf
PUBLIC ZLIB::ZLIB
${ARROW_LIBRARIES}
PUBLIC ${ARROW_LIBRARIES}
cudf::Thrust
rmm::rmm
PRIVATE cuco::cuco
ZLIB::ZLIB
nvcomp::nvcomp)

# Add Conda library, and include paths if specified
Expand Down

0 comments on commit 91d412b

Please sign in to comment.