Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch rapids-cmake to work around cuCollection cmake issue #9075

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 19, 2021

Fixes #9073.

Adds explicit fetching of rapids-cmake v21.10 to work around build issues outside of the conda environment caused by NVIDIA/cuCollections#104.

@jlowe jlowe added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue non-breaking Non-breaking change labels Aug 19, 2021
@jlowe jlowe self-assigned this Aug 19, 2021
@jlowe jlowe requested a review from a team as a code owner August 19, 2021 20:34
@jlowe
Copy link
Member Author

jlowe commented Aug 19, 2021

I checked with @robertmaynard and he was OK with this fix to unblock the Java build while waiting for the cuCollections fix or #9030.

@jlowe
Copy link
Member Author

jlowe commented Aug 19, 2021

rerun tests

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@8b02ca3). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 61a6772 differs from pull request most recent head b27ec1d. Consider uploading reports for the commit b27ec1d to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9075   +/-   ##
===============================================
  Coverage                ?   10.73%           
===============================================
  Files                   ?      114           
  Lines                   ?    19058           
  Branches                ?        0           
===============================================
  Hits                    ?     2046           
  Misses                  ?    17012           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b02ca3...b27ec1d. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Aug 20, 2021

rerun tests

1 similar comment
@ajschmidt8
Copy link
Member

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Aug 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3fec3d8 into rapidsai:branch-21.10 Aug 20, 2021
@jlowe jlowe deleted the fix-jni-build branch August 20, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Java cudf build fails in non-conda environment with unable to find rapids-cmake
4 participants