Use the new RAPIDS.cmake to fetch rapids-cmake #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Aug 20, 2021
Fixes #9073. Adds explicit fetching of rapids-cmake v21.10 to work around build issues outside of the conda environment caused by NVIDIA/cuCollections#104. Authors: - Jason Lowe (https://github.com/jlowe) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Alessandro Bellina (https://github.com/abellina) URL: #9075
|
rerun tests |
The original approach of using FetchContent naively has a subtle bug when multiple projects that use rapids-cmake are combined together inside as sibling projects. This bug causes any `include(rapids-*)` commands to fail, causing CMake errors. By using `RAPIDS.cmake` we can resolve this issue and remove the new complex logic from each consumer.
robertmaynard
force-pushed
the
use_latest_rapids_cmake
branch
from
09a7b9b to
484175b
Compare
This was referenced Oct 6, 2021
|
@jrhemstad can we merge this soon? We need it for the raft-dependency-consolidation PRs. |
jrhemstad
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original approach of using FetchContent naively has a subtle bug when
multiple projects that use rapids-cmake are combined together inside as
sibling projects. This bug causes any
include(rapids-*)commands to fail,causing CMake errors.
By using
RAPIDS.cmakewe can resolve this issue and remove the new complexlogic from each consumer.