Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation errors in groupby benchmarks. #9072

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix compilation errors in groupby benchmarks. #9072

merged 1 commit into from
Aug 19, 2021

Conversation

nvdbaranec
Copy link
Contributor

Fixes a couple of compilation errors caused by new groupby_aggregation class.

@nvdbaranec nvdbaranec added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 19, 2021
@nvdbaranec nvdbaranec requested a review from a team as a code owner August 19, 2021 16:28
@nvdbaranec nvdbaranec requested a review from cwharris August 19, 2021 16:28
@nvdbaranec
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Aug 19, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@94c659c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2c4deaf differs from pull request most recent head 31846d9. Consider uploading reports for the commit 31846d9 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9072   +/-   ##
===============================================
  Coverage                ?   10.71%           
===============================================
  Files                   ?      114           
  Lines                   ?    19093           
  Branches                ?        0           
===============================================
  Hits                    ?     2046           
  Misses                  ?    17047           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c659c...31846d9. Read the comment docs.

@nvdbaranec
Copy link
Contributor Author

rerun tests

@nvdbaranec
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c3f06a5 into rapidsai:branch-21.10 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks mythrocks approved these changes

@cwharris cwharris cwharris approved these changes

Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nvdbaranec @cwharris @mythrocks @ttnghia @rgsl888prabhu