Skip to content

Commit

Permalink
Fix compilation errors in groupby benchmarks. (#9072)
Browse files Browse the repository at this point in the history
Fixes a couple of compilation errors caused by new groupby_aggregation class.

Authors:
  - https://github.com/nvdbaranec

Approvers:
  - Christopher Harris (https://github.com/cwharris)
  - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)
  - Nghia Truong (https://github.com/ttnghia)
  - MithunR (https://github.com/mythrocks)

URL: #9072
  • Loading branch information
nvdbaranec authored Aug 19, 2021
1 parent 8b02ca3 commit c3f06a5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion cpp/benchmarks/groupby/group_nth_benchmark.cu
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ void BM_pre_sorted_nth(benchmark::State& state)
std::vector<cudf::groupby::aggregation_request> requests;
requests.emplace_back(cudf::groupby::aggregation_request());
requests[0].values = vals;
requests[0].aggregations.push_back(cudf::make_nth_element_aggregation<groupby_aggregation>(-1));
requests[0].aggregations.push_back(
cudf::make_nth_element_aggregation<cudf::groupby_aggregation>(-1));

for (auto _ : state) {
cuda_event_timer timer(state, true);
Expand Down
4 changes: 2 additions & 2 deletions cpp/benchmarks/groupby/group_sum_benchmark.cu
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void BM_basic_sum(benchmark::State& state)
std::vector<cudf::groupby::aggregation_request> requests;
requests.emplace_back(cudf::groupby::aggregation_request());
requests[0].values = vals;
requests[0].aggregations.push_back(cudf::make_sum_aggregation());
requests[0].aggregations.push_back(cudf::make_sum_aggregation<cudf::groupby_aggregation>());

for (auto _ : state) {
cuda_event_timer timer(state, true);
Expand Down Expand Up @@ -97,7 +97,7 @@ void BM_pre_sorted_sum(benchmark::State& state)
std::vector<cudf::groupby::aggregation_request> requests;
requests.emplace_back(cudf::groupby::aggregation_request());
requests[0].values = vals;
requests[0].aggregations.push_back(cudf::make_sum_aggregation());
requests[0].aggregations.push_back(cudf::make_sum_aggregation<cudf::groupby_aggregation>());

for (auto _ : state) {
cuda_event_timer timer(state, true);
Expand Down

0 comments on commit c3f06a5

Please sign in to comment.