Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some debug print statements from gtests #9048

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

davidwendt
Copy link
Contributor

While working on #8883 I found some print statements that were a bit annoying while trying to narrow done the cuda-memcheck errors. This PR removes them. I don't think any of these are hard to recode if needed for a specific debug session but I feel they should not be inflicted on developers who are debugging other issues.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 16, 2021
@davidwendt davidwendt self-assigned this Aug 16, 2021
@davidwendt davidwendt requested a review from a team as a code owner August 16, 2021 21:36
@davidwendt davidwendt requested review from trxcllnt and vuule August 16, 2021 21:36
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@abe57f8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ad8965a differs from pull request most recent head 2552209. Consider uploading reports for the commit 2552209 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9048   +/-   ##
===============================================
  Coverage                ?   10.65%           
===============================================
  Files                   ?      114           
  Lines                   ?    19080           
  Branches                ?        0           
===============================================
  Hits                    ?     2033           
  Misses                  ?    17047           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe57f8...2552209. Read the comment docs.

@vuule
Copy link
Contributor

vuule commented Aug 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0410bf9 into rapidsai:branch-21.10 Aug 17, 2021
@davidwendt davidwendt deleted the remove-print-statements branch August 18, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants