Skip to content

Commit

Permalink
Remove some debug print statements from gtests (#9048)
Browse files Browse the repository at this point in the history
While working on #8883 I found some print statements that were a bit annoying while trying to narrow done the cuda-memcheck errors. This PR removes them. I don't think any of these are hard to recode if needed for a specific debug session but I feel they should not be inflicted on developers who are debugging other issues.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Nghia Truong (https://github.com/ttnghia)

URL: #9048
  • Loading branch information
davidwendt authored Aug 17, 2021
1 parent 20ea823 commit 0410bf9
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 47 deletions.
3 changes: 0 additions & 3 deletions cpp/tests/encode/encode_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ TYPED_TEST(EncodeNumericTests, SimpleWithNulls)
cudf::test::fixed_width_column_wrapper<TypeParam> expect_keys{{1, 2, 3, 0}, {1, 1, 1, 0}};
auto const result = cudf::encode(cudf::table_view({input}));

cudf::test::print(result.first->view().column(0));
cudf::test::print(expect_keys);

CUDF_TEST_EXPECT_COLUMNS_EQUAL(result.first->view().column(0), expect_keys);
CUDF_TEST_EXPECT_COLUMNS_EQUAL(result.second->view(), expect);
}
Expand Down
26 changes: 0 additions & 26 deletions cpp/tests/rolling/grouped_rolling_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -139,19 +139,6 @@ class GroupedRollingTest : public cudf::test::BaseFixture {
auto reference = create_reference_output(
op, input, expected_grouping, preceding_window, following_window, min_periods);

#ifndef NDEBUG
std::cout << "input:\n";
cudf::test::print(input, std::cout, ", ");
std::cout << "\n";
std::cout << "output:\n";
cudf::test::print(*output, std::cout, ", ");
std::cout << "\n";
std::cout << "reference:\n";
cudf::test::print(*reference, std::cout, ", ");
std::cout << "\n";
std::cout << "\n";
#endif

CUDF_TEST_EXPECT_COLUMNS_EQUAL(*output, *reference);
}

Expand Down Expand Up @@ -709,19 +696,6 @@ class GroupedTimeRangeRollingTest : public cudf::test::BaseFixture {
following_window_in_days,
min_periods);

#ifndef NDEBUG
std::cout << "input:\n";
cudf::test::print(input, std::cout, ", ");
std::cout << "\n";
std::cout << "output:\n";
cudf::test::print(*output, std::cout, ", ");
std::cout << "\n";
std::cout << "reference:\n";
cudf::test::print(*reference, std::cout, ", ");
std::cout << "\n";
std::cout << "\n";
#endif

CUDF_TEST_EXPECT_COLUMNS_EQUAL(*output, *reference);
}

Expand Down
13 changes: 0 additions & 13 deletions cpp/tests/rolling/rolling_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -190,19 +190,6 @@ class RollingTest : public cudf::test::BaseFixture {
auto reference =
create_reference_output(op, input, preceding_window, following_window, min_periods);

#if 0
std::cout << "input:\n";
cudf::test::print(input, std::cout, ", ");
std::cout << "\n";
std::cout << "output:\n";
cudf::test::print(*output, std::cout, ", ");
std::cout << "\n";
std::cout << "reference:\n";
cudf::test::print(reference, std::cout, ", ");
std::cout << "\n";
std::cout << "\n";
#endif

CUDF_TEST_EXPECT_COLUMNS_EQUAL(*output, *reference);
}

Expand Down
5 changes: 0 additions & 5 deletions cpp/tests/structs/structs_column_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -433,11 +433,6 @@ TYPED_TEST(TypedStructColumnWrapperTest, TestListsOfStructs)

cudf::test::expect_columns_equivalent(expected_unchanged_struct_col,
cudf::lists_column_view(*list_col).child());

#ifndef NDEBUG
std::cout << "Printing list col: \n";
cudf::test::print(*list_col);
#endif
}

TYPED_TEST(TypedStructColumnWrapperTest, ListOfStructOfList)
Expand Down

0 comments on commit 0410bf9

Please sign in to comment.