Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow where() to work with a Series and other=cudf.NA #9019

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

sarahyurick
Copy link
Contributor

Fixes #8969.

Duplicate of #8977 - some of the checks are erroring and I'm seeing strange messages about the git commits, so I'm re-opening the PR here to see if that fixes it.

@sarahyurick sarahyurick requested a review from a team as a code owner August 11, 2021 20:41
@sarahyurick sarahyurick requested review from cwharris and isVoid August 11, 2021 20:41
@sarahyurick sarahyurick self-assigned this Aug 11, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 11, 2021
@sarahyurick sarahyurick added bug Something isn't working non-breaking Non-breaking change labels Aug 11, 2021
@sarahyurick sarahyurick changed the title [DUPLICATE] Allow where() to work with a Series and other=cudf.NA Allow where() to work with a Series and other=cudf.NA Aug 11, 2021
@sarahyurick
Copy link
Contributor Author

hi @shwina sorry for the inconvenience but I had to re-open #8977 here, could you check it over again?

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@f6ce668). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9019   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    19046           
  Branches                ?        0           
===============================================
  Hits                    ?     2017           
  Misses                  ?    17029           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ce668...21ccfd9. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Aug 11, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7461b20 into rapidsai:branch-21.10 Aug 11, 2021
@sarahyurick sarahyurick deleted the where_series_other2 branch September 21, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Allow where() to work with a Series and other=cudf.NA
2 participants