[Re-opened elsewhere] Allow where() to work with a Series and other=cudf.NA
#8977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
reviewed
Aug 5, 2021
shwina
reviewed
Aug 11, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8977 +/- ##
===============================================
Coverage ? 10.57%
===============================================
Files ? 116
Lines ? 19081
Branches ? 0
===============================================
Hits ? 2018
Misses ? 17063
Partials ? 0 Continue to review full report at Codecov.
|
sarahyurick
changed the title
where() to work with a Series and other=cudf.NAwhere() to work with a Series and other=cudf.NA
|
Checks failing due to git commit issues, re-opened at #9019. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 11, 2021
Fixes #8969. Duplicate of #8977 - some of the checks are erroring and I'm seeing strange messages about the git commits, so I'm re-opening the PR here to see if that fixes it. Authors: - Sarah Yurick (https://github.com/sarahyurick) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: #9019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8969. Currently, the assertion fails when handling a
cudf.NAversuspd.NAbecause the column's dtypes are different; Pandas makes it an object where as we make it a float64/int64.Update: I just use
check_dtype=Falsein theassert_eq()function.