Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cufilejni build w/ c++17 #8877

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

pxLi
Copy link
Member

@pxLi pxLi commented Jul 28, 2021

Signed-off-by: Peixin Li [email protected]

cufilejni was not specified CXX standard, so if ENABLE_GDS=ON, it will fail w/

error: 'is_same_v' is not a member of 'std'; did you mean 'is_same'

@pxLi pxLi added Java Affects Java cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 28, 2021
@pxLi pxLi requested review from jlowe and mythrocks July 28, 2021 02:19
@pxLi pxLi self-assigned this Jul 28, 2021
@pxLi pxLi requested a review from a team as a code owner July 28, 2021 02:19
@github-actions github-actions bot added the CMake CMake build issue label Jul 28, 2021
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I hadn't tried reproducing the failure with USE_GDS=ON.

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #8877 (7e82198) into branch-21.10 (18f7c01) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8877      +/-   ##
================================================
- Coverage         10.67%   10.59%   -0.09%     
================================================
  Files               110      116       +6     
  Lines             18271    19037     +766     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17020     +700     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279f9a4...7e82198. Read the comment docs.

@pxLi
Copy link
Member Author

pxLi commented Jul 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 904222b into rapidsai:branch-21.10 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants