Skip to content

Commit

Permalink
fix cufilejni build w/ c++17 (#8877)
Browse files Browse the repository at this point in the history
Signed-off-by: Peixin Li <[email protected]>

cufilejni was not specified CXX standard, so if `ENABLE_GDS=ON`, it will fail w/ 
```
error: 'is_same_v' is not a member of 'std'; did you mean 'is_same'
```

Authors:
  - pxLi (https://github.com/pxLi)

Approvers:
  - MithunR (https://github.com/mythrocks)

URL: #8877
  • Loading branch information
pxLi authored Jul 28, 2021
1 parent 5d7c172 commit 904222b
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions java/src/main/native/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,14 @@ target_compile_definitions(cudfjni

if(USE_GDS)
add_library(cufilejni SHARED "src/CuFileJni.cpp")
SET_TARGET_PROPERTIES(cufilejni
PROPERTIES BUILD_RPATH "\$ORIGIN"
# set target compile options
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
CUDA_STANDARD 17
CUDA_STANDARD_REQUIRED ON
)
target_include_directories(cufilejni PRIVATE "${cuFile_INCLUDE_DIRS}")
target_link_libraries(cufilejni PRIVATE cudfjni "${cuFile_LIBRARIES}")
endif(USE_GDS)
Expand Down

0 comments on commit 904222b

Please sign in to comment.