-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add struct accessor to dask-cudf #8874
Conversation
merging recent commits to test implementation on current version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @NV-jpt - Looking good so far! It looks like you need to resolve some conflicts with branch-21.10 and add pre-commit to your environment to help with formatting.
Co-authored-by: Richard (Rick) Zamora <[email protected]>
@sarahyurick - I suspect that the most-natural place for the dask-cudf |
… struct-accessor Committed a change thru github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting very close - Nice work @NV-jpt !
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8874 +/- ##
===============================================
Coverage ? 10.77%
===============================================
Files ? 114
Lines ? 19069
Branches ? 0
===============================================
Hits ? 2054
Misses ? 17015
Partials ? 0 Continue to review full report at Codecov.
|
…ropriate error handling
…of raising them at the dask-cudf layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. My only suggestion is to avoid repeating the same "data"
parameters in test_accessor.py
(see my comment). Also, could you make the title of the PR slightly more descriptive? For example: "Add struct accessor to dask-cudf"
… used for testing
rerun tests |
rerun tests |
1 similar comment
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@gpucibot merge |
This PR implements 'Struct Accessor' requested feature in dask-cudf (Issue #8658)
StructMethod class implemented to expose 'field(key)' method in dask-cudf