Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add struct.explode() method #8729

Merged
merged 28 commits into from
Jul 20, 2021
Merged

Add struct.explode() method #8729

merged 28 commits into from
Jul 20, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jul 13, 2021 •
edited
Loading

Part of #8660. Note that the issue is asking for this feature in dask-cudf, which this PR does not implement.

Depends on: #8306

shwina added 19 commits April 29, 2021 10:45
@shwina
Add initial Buffer.copy()
ab35f7d
@shwina
Add Buffer copy tests
72197a2
@shwina
Docstring
9b4611b
@shwina
Initial refactor of ColumnMethods
8d64f84
@shwina
More refactoring
7d9fcc5
@shwina
More refactoring
8911fea
@shwina
More refactoring
2a32405
@shwina
parent can never be None
b713e13
@shwina
Redundant docstring
50e6fa3
@shwina
MyPy fix
9d91246
@shwina
Merge branch 'branch-21.06' of https://github.com/rapidsai/cudf into …
4e7d481 
…column-methods-cleanup
@shwina
Fix leaves method
a2bd07a
@shwina
Merge branch 'branch-21.08' of https://github.com/rapidsai/cudf into …
6142f96 
…column-methods-cleanup
@shwina
Merge branch 'column-methods-cleanup' of github.com:shwina/cudf into …
d9583d0 
…column-methods-cleanup
@shwina
Merge branch 'branch-21.08' of https://github.com/rapidsai/cudf into …
e55c4e8 
…column-methods-cleanup
@shwina
Move copyright
487378c
@shwina
Add a to_struct() method
e014082
@shwina
Merge branch 'column-methods-cleanup' into struct-explode
a1fc9f2
@shwina
Add struct.explode() method
cb78803
@shwina shwina requested a review from a team as a code owner July 13, 2021 17:41
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 13, 2021
@shwina shwina requested review from vyasr and brandon-b-miller and removed request for marlenezw and skirui-source July 13, 2021 17:41
@codecov
Copy link

codecov bot commented Jul 14, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@7ee347c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8729   +/-   ##
===============================================
  Coverage                ?   10.49%           
===============================================
  Files                   ?      116           
  Lines                   ?    18988           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16995           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee347c...f699e2a. Read the comment docs.

@shwina shwina added feature request New feature or request non-breaking Non-breaking change labels Jul 14, 2021
@shwina shwina requested a review from brandon-b-miller July 19, 2021 13:18
@shwina
Copy link
Contributor Author

shwina commented Jul 20, 2021

rerun tests

vyasr
vyasr requested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor requests, mostly just nits and being careful.

python/cudf/cudf/core/column/struct.py Show resolved Hide resolved
python/cudf/cudf/core/column/struct.py Show resolved Hide resolved
python/cudf/cudf/core/column/struct.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
@vyasr vyasr self-requested a review July 20, 2021 19:37
@vyasr
Copy link
Contributor

vyasr commented Jul 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cdcc91c into rapidsai:branch-21.08 Jul 20, 2021
@jakirkham jakirkham mentioned this pull request Jul 21, 2021
Closed
@sarahyurick sarahyurick mentioned this pull request Jul 27, 2021
Closed
@rjzamora rjzamora mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckernick beckernick beckernick left review comments

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shwina @vyasr @beckernick @brandon-b-miller