Support bracket syntax for cudf::strings::replace_with_backrefs group index values #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8841 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19034 +763
================================================
+ Hits 1951 2017 +66
- Misses 16320 17017 +697
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
cwharris
approved these changes
Aug 6, 2021
|
@gpucibot merge |
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Aug 9, 2021
… index values (rapidsai#8841) Closes rapidsai#8816 The current `\d` syntax for the replacement template parameter will fail if a number immediately follows the index pattern as described in rapidsai#8816. This PR adds support for the `${d}` pattern but only if the `\d` pattern is not found in the replacement string. This should minimize breaking any current templates already being used with this API. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Christopher Harris (https://github.com/cwharris) URL: rapidsai#8841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8816
The current
\dsyntax for the replacement template parameter will fail if a number immediately follows the index pattern as described in #8816. This PR adds support for the${d}pattern but only if the\dpattern is not found in the replacement string. This should minimize breaking any current templates already being used with this API.