Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve regex backref replace casts that need to add a postfix digit #3163

Closed
jlowe opened this issue Aug 6, 2021 · 2 comments
Closed

Improve regex backref replace casts that need to add a postfix digit #3163

jlowe opened this issue Aug 6, 2021 · 2 comments
Labels
performance A performance related task/issue task Work required that improves the product but is not user facing

Comments

@jlowe
Copy link
Member

jlowe commented Aug 6, 2021

rapidsai/cudf#8841 allows us to specify a boundary around replacement groups so we can follow a group by a digit (e.g.: 0). This should allow us to simplify some of the regex replaces used for timestamp casting.

@jlowe jlowe added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing labels Aug 6, 2021
@jlowe
Copy link
Member Author

jlowe commented Aug 6, 2021

@andygrove FYI, not high priority, but it may be useful if you run across this use case again in some new code.

@Salonijain27 Salonijain27 added performance A performance related task/issue and removed ? - Needs Triage Need team to review and classify labels Aug 10, 2021
@jlowe
Copy link
Member Author

jlowe commented Apr 28, 2022

I don't think this applies to the current timestamp casting code. Even if it does, if we want to get serious about timestamp casting performance, we need to move away from regex searching.

@jlowe jlowe closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue task Work required that improves the product but is not user facing
Projects
None yet
Development

No branches or pull requests

2 participants