Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiled binary ops in libcudf, python and java #8741

Merged
merged 17 commits into from
Aug 23, 2021
Merged

Enable compiled binary ops in libcudf, python and java #8741

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1ccc242
add experimental::detail::binary_operation
karthikeyann Jul 14, 2021
0734a85
use experimental::detail::binary_operation in libcudf functions
karthikeyann Jul 14, 2021
d65fe3a
use compiled experimental::binary_operation in python
karthikeyann Jul 14, 2021
010bd4a
use compiled experimental::binary_operation in java
karthikeyann Jul 14, 2021
0f35ff2
add logical_and logical_or to bool output type list
karthikeyann Jul 14, 2021
67c94ab
add NullMax, NullMin string unit tests
karthikeyann Jul 15, 2021
06fb13a
Merge branch 'branch-21.08' of github.com:rapidsai/cudf into fea-enab…
karthikeyann Jul 20, 2021
6684fe2
enable decimal32 decimal64 conversions
karthikeyann Jul 20, 2021
dd9fc3e
fix merge error
karthikeyann Jul 20, 2021
524bdcf
fixed point scalar to device_view fix mem access
karthikeyann Jul 22, 2021
cd3c244
Merge branch 'branch-21.10' of github.com:rapidsai/cudf into fea-enab…
karthikeyann Aug 1, 2021
50e4437
remove unused include
karthikeyann Aug 2, 2021
0f5d3cf
reorg code, jit::binary_operation, compiled as cudf::binary_operation
karthikeyann Aug 16, 2021
35c9ebb
review comments jni, cython fix as well
karthikeyann Aug 16, 2021
61e22bd
remove debug rmm_mode=cuda cmake change
karthikeyann Aug 17, 2021
62b52d7
delete commented code
karthikeyann Aug 19, 2021
e7e81ce
Merge branch 'branch-21.10' of github.com:rapidsai/cudf into fea-enab…
karthikeyann Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function(ConfigureTest CMAKE_TEST_NAME )
set_target_properties(${CMAKE_TEST_NAME}
PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$<BUILD_INTERFACE:${CUDF_BINARY_DIR}/gtests>")
target_link_libraries(${CMAKE_TEST_NAME} PRIVATE cudftestutil GTest::gmock_main GTest::gtest_main)
add_test(NAME ${CMAKE_TEST_NAME} COMMAND ${CMAKE_TEST_NAME} --rmm_mode=cuda)
add_test(NAME ${CMAKE_TEST_NAME} COMMAND ${CMAKE_TEST_NAME})
endfunction()

###################################################################################################
Expand Down
3 changes: 1 addition & 2 deletions cpp/tests/binaryop/binop-compiled-fixed_point-test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,8 +684,7 @@ TYPED_TEST(FixedPointCompiledTestBothReps, FixedPointBinaryOpThrows)
EXPECT_THROW(cudf::binary_operation(col, col, cudf::binary_operator::LESS, non_bool_type),
cudf::logic_error);
// Allowed now, but not allowed in jit.
// EXPECT_THROW(cudf::binary_operation(col, col, cudf::binary_operator::MUL,
// float_type),
// EXPECT_THROW(cudf::binary_operation(col, col, cudf::binary_operator::MUL, float_type),
karthikeyann marked this conversation as resolved.
Show resolved Hide resolved
// cudf::logic_error);
}

Expand Down