Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiled binary ops in libcudf, python and java #8741

Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use compiled experimental::binary_operation in java
karthikeyann committed Jul 14, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 010bd4aad10f87935ebc746e1b33f06766a7a95f
8 changes: 4 additions & 4 deletions java/src/main/native/src/ColumnViewJni.cpp
Original file line number Diff line number Diff line change
@@ -1104,8 +1104,8 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_ColumnView_binaryOpVV(JNIEnv *env, j

cudf::data_type n_data_type = cudf::jni::make_data_type(out_dtype, scale);
cudf::binary_operator op = static_cast<cudf::binary_operator>(int_op);
std::unique_ptr<cudf::column> result = cudf::binary_operation(
*lhs, *rhs, op, n_data_type);
std::unique_ptr<cudf::column> result =
cudf::experimental::binary_operation(*lhs, *rhs, op, n_data_type);
return reinterpret_cast<jlong>(result.release());
}
CATCH_STD(env, 0);
@@ -1136,8 +1136,8 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_ColumnView_binaryOpVS(JNIEnv *env, j
cudf::data_type n_data_type = cudf::jni::make_data_type(out_dtype, scale);

cudf::binary_operator op = static_cast<cudf::binary_operator>(int_op);
std::unique_ptr<cudf::column> result = cudf::binary_operation(
*lhs, *rhs, op, n_data_type);
std::unique_ptr<cudf::column> result =
cudf::experimental::binary_operation(*lhs, *rhs, op, n_data_type);
return reinterpret_cast<jlong>(result.release());
}
CATCH_STD(env, 0);
3 changes: 2 additions & 1 deletion java/src/main/native/src/ScalarJni.cpp
Original file line number Diff line number Diff line change
@@ -467,7 +467,8 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_Scalar_binaryOpSV(JNIEnv *env, jclas
cudf::data_type n_data_type = cudf::jni::make_data_type(out_dtype, scale);

cudf::binary_operator op = static_cast<cudf::binary_operator>(int_op);
std::unique_ptr<cudf::column> result = cudf::binary_operation(*lhs, *rhs, op, n_data_type);
std::unique_ptr<cudf::column> result =
cudf::experimental::binary_operation(*lhs, *rhs, op, n_data_type);
return reinterpret_cast<jlong>(result.release());
}
CATCH_STD(env, 0);