-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fix for CUDA 11.3 #8635
Build fix for CUDA 11.3 #8635
Conversation
We're seeing build failures when trying to compile cudf on the DLFW 21.06 container (which is on CUDA 11.3). This change works around one of the build problems by changing to reduce the use of ```auto``` and initializer lists.
Fwiw, here is the compile error without this change. Build Log
|
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8635 +/- ##
===============================================
Coverage ? 10.61%
===============================================
Files ? 109
Lines ? 18646
Branches ? 0
===============================================
Hits ? 1980
Misses ? 16666
Partials ? 0 Continue to review full report at Codecov.
|
I'm not sure if my previous issues with CUDA 11.3 still persist (https://nvidia.slack.com/archives/CDTANRCTT/p1621018311286700). If so, maybe this fix is not enough. @robertmaynard should know more about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that locally that this fixes the 11.3 regression when using std::pair
.
I fixed that issue in #8525 |
@benfred can we merge this PR? |
@galipremsagar this PR is safe to merge - This is isn't sufficient on its own to get cudf compiling with 11.3 though. This change fixes the one build break - but there are build time issues with files like tokenize.cu that still exist. |
I'm going to close this: it's not enough on its own to get cudf building with cuda 11.3, and isn't needed for cuda 11.4. Feel free to re-open / merge if you want though. |
We're seeing build failures when trying to compile cudf on the DLFW 21.06
container (which is on CUDA 11.3). This change works around one of the
build problems by changing to reduce the use of
auto
and initializerlists in cpp/src/io/json/reader_impl.cu