Correct the last warnings and issues when using newer cuda versions #8525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of `std::move` on the components of std::pair was causing issues with certain nvcc compiler versions. By moving to structured bindings we can get the same outcome but avoid the issue.
nvcc 11.3+ generates false positive warnings with variadic functions under a couple of scenarios: - multiple overloads of the same class function exist with SFINAE, and one doesn't use all parameters. - `if constexpr` causes some branches to not use all parameters. For both of these case all usages will generate warnings, even when they aren't activating the issue.
robertmaynard
added
3 - Ready for Review
rgsl888prabhu
approved these changes
Jun 15, 2021
harrism
approved these changes
Jun 16, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8525 +/- ##
===============================================
Coverage ? 82.95%
===============================================
Files ? 109
Lines ? 18226
Branches ? 0
===============================================
Hits ? 15120
Misses ? 3106
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the last round of changes to get cudf to compile cleanly with newer CUDA versions
std::moveon temporaries by using structured bindings ( clamp.cu )if constexpr, re-ordering SFINAE logic, adding fake usage via empty function/structs ) and nothing but removing the variadic template worked.