Remove unneeded includes from cudf::string_view headers #8594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
hyperbolic2346
requested changes
Jun 23, 2021
devavret
approved these changes
Jun 24, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8594 +/- ##
===============================================
Coverage ? 83.00%
===============================================
Files ? 109
Lines ? 18234
Branches ? 0
===============================================
Hits ? 15136
Misses ? 3098
Partials ? 0 Continue to review full report at Codecov.
|
hyperbolic2346
approved these changes
Jun 28, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
This PR makes small improvements for the I/O code. Specifically, - Place type constraint on a template class to allow only for rvalue argument. In addition, replace `std::move` with `std::forward` to make the code more *apparently* consistent with the convention, i.e. use `std::move()` on the rvalue references, and `std::forward` on the forwarding references (Effective modern C++ item 25). - Alleviate (but not completely resolve) an existing cuFile driver close issue by removing the explicit driver close call. See #17121 - Minor typo fix (`struct` → `class`). Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) Approvers: - Nghia Truong (https://github.com/ttnghia) - Vukasin Milovanovic (https://github.com/vuule) URL: #17105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some unnecessary include statements from
string_view.hppandstring_view.cuh. It also includes a#ifdefto help re-use this class in the https://github.com/rapidsai/strings_udf repo to avoid maintaining a separate string-view class that can be NVRTC compiled with https://github.com/NVIDIA/jitify.Also removing the
VARIABLE_CHAR_WIDTHconstant which is no longer needed and should've been removed in a previous PR.