-
Notifications
You must be signed in to change notification settings - Fork 919
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove unneeded includes from cudf::string_view headers (#8594)
This PR removes some unnecessary include statements from `string_view.hpp` and `string_view.cuh`. It also includes a `#ifdef` to help re-use this class in the https://github.com/rapidsai/strings_udf repo to avoid maintaining a separate string-view class that can be NVRTC compiled with https://github.com/NVIDIA/jitify. Also removing the `VARIABLE_CHAR_WIDTH` constant which is no longer needed and should've been removed in a previous PR. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Devavret Makkar (https://github.com/devavret) - Mike Wilson (https://github.com/hyperbolic2346) URL: #8594
- Loading branch information
1 parent
5ff663a
commit e6a0fe3
Showing
2 changed files
with
15 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters