Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JNI for strings:repeat_strings that repeats each string separately by different numbers of times #8572

Merged
merged 52 commits into from
Jul 26, 2021
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
f0b5ff7
Add doxygen
ttnghia Jun 17, 2021
a61c1e7
Finish implementation
ttnghia Jun 18, 2021
2639f9a
Finish unit tests
ttnghia Jun 18, 2021
dbbfbf9
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jun 18, 2021
0dec873
Fix merge conflicts
ttnghia Jun 18, 2021
143f853
Rename parameter back to `input`
ttnghia Jun 21, 2021
b39bb06
Fix typo
ttnghia Jun 21, 2021
ae40591
Rewrite using type_dispatcher for different integer types
ttnghia Jun 21, 2021
8612f61
Fix comment typo
ttnghia Jun 21, 2021
3dfec42
Remove input check for int32_t data type
ttnghia Jun 21, 2021
d230498
Remove bool type from the expecting types for `repeat_times` data type
ttnghia Jun 21, 2021
7ec3c76
Merge branch 'repeat_strings' into jni_repeat_strings
ttnghia Jun 21, 2021
c56627d
Implement Java binding for repeatStringsWithColumnRepeatTimes
ttnghia Jun 21, 2021
834892d
Implement JNI for repeatStringsWithColumnRepeatTimes
ttnghia Jun 21, 2021
c4d3a36
Fix repeatString with scalar repeat times
ttnghia Jun 21, 2021
f534372
Implement overflow check for the new API, as it can't be done outside…
ttnghia Jun 21, 2021
554d20d
Update doxygen
ttnghia Jun 21, 2021
d00ba01
Add typed tests for various types of `repeat_times` column
ttnghia Jun 21, 2021
5b5c2a4
Fix doxygen
ttnghia Jun 21, 2021
d488eca
Simplify overflow checking
ttnghia Jun 21, 2021
8498fc6
Just re-order code
ttnghia Jun 21, 2021
855a774
Add a parameter to allow turning on/off overflow checking
ttnghia Jun 24, 2021
e5f5db8
Implement overflow checking
ttnghia Jun 25, 2021
50f05fd
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jun 25, 2021
0bcf8d8
Redesign the API and update doxygen
ttnghia Jun 25, 2021
c7b7c3b
Add an optional column of pre-computed output strings offsets
ttnghia Jul 7, 2021
f6d7ee3
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 8, 2021
d22c4e5
Finish implementation
ttnghia Jul 8, 2021
6124e83
Fix JNI
ttnghia Jul 8, 2021
90517aa
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 8, 2021
7795f54
Cleanup
ttnghia Jul 8, 2021
9158e4f
Remove duplicate code
ttnghia Jul 9, 2021
5e37782
Add test for computing string output sizes that causes overflow
ttnghia Jul 9, 2021
4dfca75
Fix test build error
ttnghia Jul 9, 2021
95cb6c0
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 9, 2021
91c414e
Simple fix comment typo
ttnghia Jul 9, 2021
20f79c6
Merge branch 'repeat_strings' into jni_repeat_strings
ttnghia Jul 12, 2021
5334708
Merge branch 'branch-21.08' into jni_repeat_strings
ttnghia Jul 12, 2021
0a173b8
WIP
ttnghia Jul 20, 2021
2c49666
Merge branch 'branch-21.08' into jni_repeat_strings
ttnghia Jul 21, 2021
31b3aa9
Rewrite javadoc
ttnghia Jul 21, 2021
62c24f5
Add Java API for repeatStringsOutputSizes
ttnghia Jul 22, 2021
d5c5964
Rewrite tests
ttnghia Jul 22, 2021
2c8ac37
Rewrite the output types for repeatStringsOutputSizes
ttnghia Jul 22, 2021
2df33d6
Rename functions
ttnghia Jul 22, 2021
22ab360
Add tests with pre-computed output string sizes
ttnghia Jul 22, 2021
272c24e
Merge branch 'branch-21.08' into jni_repeat_strings
ttnghia Jul 22, 2021
b537d81
Merge branch 'branch-21.10' into jni_repeat_strings
ttnghia Jul 22, 2021
8331836
Rename functions and variables
ttnghia Jul 23, 2021
2f32d40
Fix typo
ttnghia Jul 23, 2021
69000ae
Rewrite javadoc and add public qualifier for class
ttnghia Jul 23, 2021
7488a39
Merge branch 'branch-21.10' into jni_repeat_strings
ttnghia Jul 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'branch-21.10' into jni_repeat_strings
ttnghia committed Jul 22, 2021
commit b537d81f8eaf56ce3ccd29de920da08fb0a26306

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.