Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JNI for strings:repeat_strings that repeats each string separately by different numbers of times #8572

Merged
merged 52 commits into from
Jul 26, 2021
Merged

Implement JNI for strings:repeat_strings that repeats each string separately by different numbers of times #8572

merged 52 commits into from
Jul 26, 2021

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jun 21, 2021 •
edited
Loading

This is a follow up work on #8491 so that cudf's strings::repeat_strings fully supports StringRepeat SQL expression in Apache Spark.

This PR also rewrites some existing code, including re-formatting code and changes in doxygen.

@ttnghia ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team depends on libcudf Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS strings strings issues (C++ and Python) non-breaking Non-breaking change labels Jun 21, 2021
@ttnghia ttnghia requested a review from a team June 21, 2021 16:12
@ttnghia ttnghia self-assigned this Jun 21, 2021
@ttnghia ttnghia requested a review from a team as a code owner June 21, 2021 16:12
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 21, 2021
@ttnghia ttnghia marked this pull request as draft June 21, 2021 16:12
@ttnghia ttnghia requested review from vyasr and brandon-b-miller and removed request for a team July 22, 2021 22:07
@github-actions github-actions bot removed CMake CMake build issue Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jul 22, 2021
@ttnghia ttnghia changed the title Implement JNI for strings:repeat_strings that repeats each string separately by different numbers of times [skip ci] Implement JNI for strings:repeat_strings that repeats each string separately by different numbers of times Jul 22, 2021
@ttnghia ttnghia requested a review from jlowe July 22, 2021 22:09
@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 22, 2021

Rerun tests.

hyperbolic2346
hyperbolic2346 reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure I should be a reviewer on this one.

@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 24, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 24, 2021

@gpucibot merge

@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 26, 2021

Rerun tests.

1 similar comment
@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 26, 2021

Rerun tests.

@rapids-bot rapids-bot bot merged commit 7bb16fa into rapidsai:branch-21.10 Jul 26, 2021
@ttnghia ttnghia deleted the jni_repeat_strings branch August 6, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperbolic2346 hyperbolic2346 hyperbolic2346 left review comments

@jlowe jlowe jlowe approved these changes

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttnghia @jlowe @hyperbolic2346