Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose half_up rounding in cuDF #8477

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Expose half_up rounding in cuDF #8477

merged 2 commits into from
Jun 10, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jun 9, 2021

No description provided.

@shwina shwina requested a review from a team as a code owner June 9, 2021 21:36
@shwina shwina requested review from marlenezw and skirui-source June 9, 2021 21:36
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 9, 2021
@shwina shwina added feature request New feature or request non-breaking Non-breaking change labels Jun 9, 2021
isVoid
isVoid reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, rest is good.

python/cudf/cudf/tests/test_series.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@e448675). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 330f823 differs from pull request most recent head b15a761. Consider uploading reports for the commit b15a761 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8477   +/-   ##
===============================================
  Coverage                ?   82.84%           
===============================================
  Files                   ?      109           
  Lines                   ?    17917           
  Branches                ?        0           
===============================================
  Hits                    ?    14843           
  Misses                  ?     3074           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e448675...b15a761. Read the comment docs.

cwharris
cwharris reviewed Jun 10, 2021
View reviewed changes
python/cudf/cudf/_lib/round.pyx
@@ -29,13 +29,16 @@ def round(Column input_col, int decimal_places=0):

cdef column_view input_col_view = input_col.view()
cdef unique_ptr[column] c_result

cdef cpp_rounding_method c_how = (
Copy link
Contributor

@cwharris cwharris Jun 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will there ever be more than 2 rounding methods? if so, we might create a breaking change for anyone who mis-spelled the non-default argument.

in that case, I'd suggest throwing an error if either of these rounding methods are not an exact match, so that breaking change scenario can never happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@shwina
Copy link
Contributor Author

shwina commented Jun 10, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d46e8c7 into rapidsai:branch-21.08 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@cwharris cwharris cwharris left review comments

@marlenezw marlenezw marlenezw approved these changes

@isVoid isVoid isVoid approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shwina @cwharris @galipremsagar @isVoid @rgsl888prabhu @marlenezw