Validate 'how' in Cython

rapidsai · Jun 10, 2021 · b15a761 · b15a761
1 parent b1db657
commit b15a761
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/python/cudf/cudf/_lib/round.pyx b/python/cudf/cudf/_lib/round.pyx
@@ -26,6 +26,8 @@ def round(Column input_col, int decimal_places=0, how="half_even"):
     -------
     A Column with values rounded to the given number of decimal places
     """
+    if how not in {"half_even", "half_up"}:
+        raise ValueError("'how' must be either 'half_even' or 'half_up'")
 
     cdef column_view input_col_view = input_col.view()
     cdef unique_ptr[column] c_result

diff --git a/python/cudf/cudf/core/series.py b/python/cudf/cudf/core/series.py
@@ -4776,8 +4776,6 @@ def round(self, decimals=0, how="half_even"):
         2    3.0
         dtype: float64
         """
-        if how not in {"half_up", "half_even"}:
-            raise ValueError("'how' must be either 'half_even' or 'half_up'")
         return Series(
             self._column.round(decimals=decimals, how=how),
             name=self.name,