Add str.edit_distance_matrix
#8463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
non-breaking
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8463 +/- ##
===============================================
Coverage ? 82.85%
===============================================
Files ? 109
Lines ? 17919
Branches ? 0
===============================================
Hits ? 14846
Misses ? 3073
Partials ? 0 Continue to review full report at Codecov.
|
Co-authored-by: GALI PREM SAGAR <[email protected]>
| @@ -787,6 +787,34 @@ def test_edit_distance(): | |||
| assert_eq(expected, actual) | |||
|
|
|||
|
|
|||
| def test_edit_distance_matrix(): | |||
| # normal | |||
| sr = cudf.Series(["rounded", "bounded", "bounce", "trounce", "ounce"]) | |||
There was a problem hiding this comment.
just wondering does this implementation also work for series containing lists of strings?
There was a problem hiding this comment.
It doesn't. It only accept string type series.
marlenezw
approved these changes
Jun 9, 2021
Co-authored-by: Marlene <[email protected]>
galipremsagar
approved these changes
Jun 9, 2021
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plumbs nvtext's
edit_distance_matrixto cudf python with necessary precondition checks. It also adds python tests.Closes #6341