-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Plumb edit_distance_matrix to Python #6341
Comments
This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. |
This is still necessary, and likely should be plumbed up to the Python layer given list column support. Updating the title accordingly. |
From libcudf, it looks like |
This issue has been labeled |
This PR plumbs nvtext's `edit_distance_matrix` to cudf python with necessary precondition checks. It also adds python tests. Closes #6341 Authors: - Michael Wang (https://github.com/isVoid) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Marlene (https://github.com/marlenezw) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #8463
We should plumb edit_distance_matrix to the Cython layer. This could potentially live in the
cudf._lib.nvtext.edit_distance
namespace alongside the canonicaledit_distance
.For now, I'm not sure we if need to plumb this all the way up to the Python layer. See #4569 (comment) in which we decided similarly for
find_multiple
based on efficiency and utility. With list column support we could plumb it all the way up if desired.It would be useful if we could analogously do for
edit_distance_matrix
what we can currently do forfind_multiple
.The text was updated successfully, but these errors were encountered: