-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a Decimal32Dtype in cuDF Python #8438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good aside one small question. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🙂 just one small question
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8438 +/- ##
===============================================
Coverage ? 82.95%
===============================================
Files ? 109
Lines ? 18331
Branches ? 0
===============================================
Hits ? 15206
Misses ? 3125
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm code wise. Great job!
Can you also update this page to include the new datatype? https://docs.rapids.ai/api/cudf/stable/basics.html
@gpucibot merge |
Fixes: #8218
Similarly to libcudf's 64-bit decimal type, this PR exposes the
Decimal32Dtype
and its correspondingDecimal32Column
type. Following this implementation, user can create a series or dataframe withdecimal32
dtype.Note: Only
to_arrow
andfrom_arrow
methods are currently being supported.Example: