-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DataFrame diff() #9817
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #9817 +/- ##
================================================
+ Coverage 10.42% 10.47% +0.04%
================================================
Files 119 122 +3
Lines 20603 20496 -107
================================================
- Hits 2148 2147 -1
+ Misses 18455 18349 -106
Continue to review full report at Codecov.
|
Removing my review request since this PR looks to be pretty well-covered by other reviewers. |
rerun tests |
1 similar comment
rerun tests |
@bdice @isVoid in response to you review comment above, here's an example:
This PR doesn;t cover timestamps, so should I go ahead and get this merged first ( add a TO-DO/ file follow-up issue)? |
@skirui-source I see that this is already implemented for These should be relaxed to support any type that can be subtracted: cudf/python/cudf/cudf/core/series.py Lines 3202 to 3205 in 82f941b
cudf/python/cudf/cudf/core/dataframe.py Lines 2666 to 2669 in 82f941b
|
I opened #10212 about enabling broader type support for timestamps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few small requests to improve the tests. Otherwise LGTM.
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
@gpucibot merge |
This PR removes all "smart quotes" from the library by enforcing a pre-commit hook. Smart quotes typically arise from copying rendered docstrings from Pandas, because Sphinx automatically transforms straight quotes into smart quotes when rendering the docs as HTML. However, the use of smart quotes is undesirable in code, and makes it difficult to do find-replace transformations if straight and smart quotes are mixed. I have made suggestions to fix this several times before, so I am making the suggestions more permanent and automatically enforceable via a pre-commit style check: - #12025 (comment) - #9817 (comment) - #9571 (comment) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #12035
Fixes: #9604 and resolves #1271
This PR introduces
diff()
method for DataFrames ofnumeric types only
. As a follow up, PR # #10212 will add support for non-numeric types (specifically timestamps/duration)for both
Series
andDataFrame