Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Raise error when unsupported arguments are passed to dask_cudf.DataFrame.sort_values #8349

Merged
merged 1 commit into from
May 26, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #8165

This PR raises error when unsupported arguments are passed to sort_values.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer non-breaking Non-breaking change labels May 25, 2021
@galipremsagar galipremsagar self-assigned this May 25, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner May 25, 2021 14:35
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 25, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels May 25, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@6db757b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8349   +/-   ##
===============================================
  Coverage                ?   82.88%           
===============================================
  Files                   ?      105           
  Lines                   ?    17877           
  Branches                ?        0           
===============================================
  Hits                    ?    14818           
  Misses                  ?     3059           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db757b...1ff75fe. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 2a19a31 into rapidsai:branch-21.06 May 26, 2021
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dask-cuDF sort_values ignores unsupported kwargs silently
3 participants