Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dask-cuDF sort_values ignores unsupported kwargs silently #8165

Closed
rjzamora opened this issue May 5, 2021 · 0 comments · Fixed by #8349
Closed

[BUG] Dask-cuDF sort_values ignores unsupported kwargs silently #8165

rjzamora opened this issue May 5, 2021 · 0 comments · Fixed by #8349
Assignees
Labels
bug Something isn't working dask Dask issue Python Affects Python cuDF API.

Comments

@rjzamora
Copy link
Member

rjzamora commented May 5, 2021

Describe the bug
The sort_values implementation in Dask-cuDF produces correct results, but does not raise an error or warning when unsupprted kwargs are supplied. A critical example is inplace.

Steps/Code to reproduce bug

import cudf, dask_cudf

df = dask_cudf.from_cudf(cudf.DataFrame({"a": [0, 1]*3}), npartitions=2)
df.sort_values("a", inplace=True)
df.compute()

Produces unsorted result:

   a
0  0
1  1
2  0
3  1
4  0
5  1

This is not because sort_values does not sort the DataFrame, but because the result is not stored "in place".

Expected behavior
I would expect dask_cudf to raise an error when an unsupported argument (like inplace) is used.

Additional context
Thanks to @bschifferer for bringing this problem to my attention.

@rjzamora rjzamora added bug Something isn't working Needs Triage Need team to review and classify Python Affects Python cuDF API. dask Dask issue labels May 5, 2021
@kkraus14 kkraus14 removed the Needs Triage Need team to review and classify label May 10, 2021
@galipremsagar galipremsagar self-assigned this May 25, 2021
rapids-bot bot pushed a commit that referenced this issue May 26, 2021
…rame.sort_values` (#8349)

Fixes: #8165 

This PR raises error when unsupported arguments are passed to `sort_values`.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)

URL: #8349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dask Dask issue Python Affects Python cuDF API.
Projects
None yet
3 participants