Added decimal writing for CSV writer #8296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for decimal writing in CSV writer
kaatish
added
feature request
kaatish
requested review from
ttnghia,
davidwendt,
vuule and
devavret
and removed request for
davidwendt
davidwendt
reviewed
May 20, 2021
Use EXPECT_EQ instead of ASSERT_EQ in test
ttnghia
approved these changes
May 20, 2021
davidwendt
approved these changes
May 20, 2021
vuule
requested changes
May 20, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8296 +/- ##
===============================================
Coverage ? 82.88%
===============================================
Files ? 105
Lines ? 17874
Branches ? 0
===============================================
Hits ? 14814
Misses ? 3060
Partials ? 0 Continue to review full report at Codecov.
|
vuule
added
5 - Ready to Merge
devavret
approved these changes
May 21, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7110
column_to_strings_fn was specialized for fixed point type to enable support for csv writer. A test was added to validate output file created by csv writer for decimal type column.