Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] support read/write csv with fixed-point decimal data #7110

Closed
2 tasks done
razajafri opened this issue Jan 10, 2021 · 3 comments
Closed
2 tasks done

[FEA] support read/write csv with fixed-point decimal data #7110

razajafri opened this issue Jan 10, 2021 · 3 comments
Assignees
@kaatish @elstehle
Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@razajafri
Copy link
Contributor

razajafri commented Jan 10, 2021 •
edited by vuule
Loading

We should support reading/writing decimal columns from/to CSV as fixed_point columns

TODO:

  • Reader
  • Writer
@razajafri razajafri added feature request New feature or request Needs Triage Need team to review and classify Spark Functionality that helps Spark RAPIDS labels Jan 10, 2021
@razajafri razajafri mentioned this issue Jan 10, 2021
Closed
27 tasks
@kkraus14 kkraus14 added cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jan 27, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@jlowe
Copy link
Contributor

jlowe commented Feb 26, 2021

This feature is still desired.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@kaatish kaatish self-assigned this May 12, 2021
@vuule vuule mentioned this issue May 13, 2021
Closed
4 tasks
@kaatish kaatish mentioned this issue May 20, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue May 21, 2021
@kaatish
Added decimal writing for CSV writer (#8296)
de579a5 
Addresses #7110 

column_to_strings_fn was specialized for fixed point type to enable support for csv writer. A test was added to validate output file created by csv writer for decimal type column.

Authors:
  - Kumar Aatish (https://github.com/kaatish)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - David Wendt (https://github.com/davidwendt)
  - Vukasin Milovanovic (https://github.com/vuule)
  - Devavret Makkar (https://github.com/devavret)

URL: #8296
@elstehle elstehle mentioned this issue Jun 14, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 23, 2021
@elstehle
Decimal support csv reader (#8511)
788bddd 
This PR adds support for decimal types in libcudf.

Specifically, the PR:
1. expands the C++ API to allow passing `std::vector<data_type>` (partially addresses #8240)
2. it moves the logic for parsing decimal types to common ground, such that it can be used for both string_to_decimal conversion and for the CSV reader.
3. adds support to the CSV reader to also accept decimal as a target type (partially addresses #7110)

Authors:
  - Elias Stehle (https://github.com/elstehle)

Approvers:
  - Devavret Makkar (https://github.com/devavret)
  - Vukasin Milovanovic (https://github.com/vuule)
  - David Wendt (https://github.com/davidwendt)

URL: #8511
@vuule vuule closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaatish kaatish

@elstehle elstehle

Labels
cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jlowe @kaatish @kkraus14 @elstehle @razajafri @vuule