Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "patch thrust to fix intmax num elements limitation in scan_by_key" #8226

Closed
wants to merge 2 commits into from

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented May 12, 2021

Reverts #8199

According to @allisonvacanti (NVIDIA/thrust#1424 (comment)) this patch will likely have adverse effect on performance. We should revert it until a better solution can be found.

@cwharris cwharris requested a review from a team as a code owner May 12, 2021 18:19
@cwharris cwharris requested a review from harrism May 12, 2021 18:19
@cwharris cwharris added the bug Something isn't working label May 12, 2021
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels May 12, 2021
@cwharris cwharris added non-breaking Non-breaking change 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond and removed CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels May 12, 2021
@cwharris cwharris requested a review from trxcllnt May 12, 2021 18:20
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #8226 (c42502e) into branch-0.20 (51336df) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c42502e differs from pull request most recent head 65d6891. Consider uploading reports for the commit 65d6891 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           branch-0.20    #8226    +/-   ##
=============================================
  Coverage        82.88%   82.89%            
=============================================
  Files              103      104     +1     
  Lines            17668    17916   +248     
=============================================
+ Hits             14645    14851   +206     
- Misses            3023     3065    +42     
Impacted Files Coverage Δ
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.20% <0.00%> (-2.72%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <0.00%> (-1.88%) ⬇️
python/cudf/cudf/core/column/struct.py 94.73% <0.00%> (-1.56%) ⬇️
python/cudf/cudf/utils/dtypes.py 82.20% <0.00%> (-1.24%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 91.28% <0.00%> (-0.88%) ⬇️
python/cudf/cudf/core/series.py 91.17% <0.00%> (-0.56%) ⬇️
python/cudf/cudf/core/index.py 92.52% <0.00%> (-0.55%) ⬇️
python/cudf/cudf/core/column/column.py 88.20% <0.00%> (-0.44%) ⬇️
python/cudf/cudf/core/column/lists.py 87.09% <0.00%> (-0.32%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9f178...65d6891. Read the comment docs.

@cwharris cwharris closed this May 17, 2021
@karthikeyann karthikeyann deleted the revert-8199-thrust-patch-intmax-scan branch May 14, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants