Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interleave_columns on ListType with nullable child #8181

Merged
merged 1 commit into from
May 10, 2021

Conversation

sperlingxx
Copy link
Contributor

Current PR is to fix interleave_columns on ListType with nullable child column. The problem is regarding list_has_null_mask as data_has_null_mask by mistake. This problem also breaks cudf::lists::concatenate_rows.

@sperlingxx sperlingxx added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 7, 2021
@sperlingxx sperlingxx requested a review from ttnghia May 7, 2021 10:10
@sperlingxx sperlingxx requested a review from a team as a code owner May 7, 2021 10:10
@sperlingxx sperlingxx requested a review from jrhemstad May 7, 2021 10:10
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 7, 2021
@ttnghia
Copy link
Contributor

ttnghia commented May 7, 2021

Great job on the unit tests. Thanks.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #8181 (3dc5eaa) into branch-0.20 (51336df) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3dc5eaa differs from pull request most recent head cbc7da1. Consider uploading reports for the commit cbc7da1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8181      +/-   ##
===============================================
- Coverage        82.88%   82.88%   -0.01%     
===============================================
  Files              103      104       +1     
  Lines            17668    17899     +231     
===============================================
+ Hits             14645    14836     +191     
- Misses            3023     3063      +40     
Impacted Files Coverage Δ
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.64% <0.00%> (-2.29%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <0.00%> (-1.88%) ⬇️
python/cudf/cudf/core/column/struct.py 94.73% <0.00%> (-1.56%) ⬇️
python/cudf/cudf/utils/dtypes.py 82.20% <0.00%> (-1.24%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 91.28% <0.00%> (-0.88%) ⬇️
python/cudf/cudf/core/series.py 91.17% <0.00%> (-0.56%) ⬇️
python/cudf/cudf/core/index.py 92.52% <0.00%> (-0.55%) ⬇️
python/cudf/cudf/core/column/column.py 88.20% <0.00%> (-0.44%) ⬇️
python/cudf/cudf/core/column/lists.py 86.98% <0.00%> (-0.43%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2207577...cbc7da1. Read the comment docs.

@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 97b2e9e into rapidsai:branch-0.20 May 10, 2021
@sperlingxx sperlingxx deleted the fix_interleave_on_lists branch May 10, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants