-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support listConcatenateByRows in Java package [skip ci] #8171
Support listConcatenateByRows in Java package [skip ci] #8171
Conversation
Signed-off-by: sperlingxx <[email protected]>
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8171 +/- ##
===============================================
- Coverage 82.88% 82.86% -0.03%
===============================================
Files 103 104 +1
Lines 17668 17884 +216
===============================================
+ Hits 14645 14820 +175
- Misses 3023 3064 +41
Continue to review full report at Codecov.
|
Signed-off-by: sperlingxx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the exact same comments as @jlowe
Signed-off-by: sperlingxx <[email protected]>
Hi @jlowe, thanks for review. I've addressed the problems you pointed out. And I made similar modifications on |
I think we should NOT merge this PR until the native fix getting merged. |
@gpucibot merge |
Sorry I missed this. Generally if something should not be merged we should mark it as a draft PR. |
Current PR is to provide Java API for
cudf::lists::concatenate_rows
, which is added in #8049.