Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support listConcatenateByRows in Java package [skip ci] #8171

Merged
merged 4 commits into from
May 7, 2021

Conversation

sperlingxx
Copy link
Contributor

Current PR is to provide Java API for cudf::lists::concatenate_rows, which is added in #8049.

@sperlingxx sperlingxx requested a review from a team as a code owner May 6, 2021 04:23
@github-actions github-actions bot added the Java Affects Java cuDF API. label May 6, 2021
@sperlingxx sperlingxx added Spark Functionality that helps Spark RAPIDS 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change and removed Java Affects Java cuDF API. labels May 6, 2021
@sperlingxx sperlingxx changed the title Support listConcatenateByRows in Java package Support listConcatenateByRows in Java package [skip ci] May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #8171 (accd7f4) into branch-0.20 (51336df) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head accd7f4 differs from pull request most recent head c009727. Consider uploading reports for the commit c009727 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8171      +/-   ##
===============================================
- Coverage        82.88%   82.86%   -0.03%     
===============================================
  Files              103      104       +1     
  Lines            17668    17884     +216     
===============================================
+ Hits             14645    14820     +175     
- Misses            3023     3064      +41     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/parquet.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/utils.py 0.00% <ø> (ø)
python/cudf/cudf/core/abc.py 91.66% <ø> (+0.17%) ⬆️
python/cudf/cudf/core/algorithms.py 82.35% <ø> (ø)
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 92.37% <ø> (+0.13%) ⬆️
python/cudf/cudf/core/column/column.py 88.20% <ø> (-0.44%) ⬇️
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 91.04% <0.00%> (-1.89%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <0.00%> (-1.88%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4715c83...c009727. Read the comment docs.

Signed-off-by: sperlingxx <[email protected]>
@github-actions github-actions bot added the Java Affects Java cuDF API. label May 6, 2021
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
java/src/main/native/src/ColumnViewJni.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the exact same comments as @jlowe

Signed-off-by: sperlingxx <[email protected]>
@sperlingxx
Copy link
Contributor Author

sperlingxx commented May 7, 2021

Hi @jlowe, thanks for review. I've addressed the problems you pointed out. And I made similar modifications on ColumnVector.stringConcatenate.

@sperlingxx
Copy link
Contributor Author

sperlingxx commented May 7, 2021

I think we should NOT merge this PR until the native fix getting merged.

@revans2
Copy link
Contributor

revans2 commented May 7, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5f9dade into rapidsai:branch-0.20 May 7, 2021
@revans2
Copy link
Contributor

revans2 commented May 7, 2021

I think we should NOT merge this PR until the native fix getting merged.

Sorry I missed this. Generally if something should not be merged we should mark it as a draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants