[REVIEW] Add python/cython bindings for str.join API
#8085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8085 +/- ##
=============================================
Coverage 82.88% 82.89%
=============================================
Files 103 103
Lines 17668 17849 +181
=============================================
+ Hits 14645 14796 +151
- Misses 3023 3053 +30
Continue to review full report at Codecov.
|
kkraus14
reviewed
Apr 28, 2021
Comment on lines
600
to
602
| # If self._column is not a ListColumn, we will have to | ||
| # split each row by character and create a ListColumn out of it. | ||
| strings_column = self._split_by_character() |
There was a problem hiding this comment.
This is really expensive both computation and memory wise. We may want to raise an issue for a future optimization to prevent us from having to materialize the offsets here.
There was a problem hiding this comment.
Opened a FEA: #8094 and added a todo here.
kkraus14
reviewed
Apr 28, 2021
kkraus14
approved these changes
Apr 29, 2021
kkraus14
added
5 - Ready to Merge
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 6, 2021
This PR adds a benchmark to the current `tokenize_benchmark.cpp` to measure the `nvtext::character_tokenize` API. PR #8085 added code for using the `nvtext::character_tokenize` function. The benchmark was also useful while investigating #8094. Also found and removed an unused variable in the code logic. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Karthikeyan (https://github.com/karthikeyann) - Nghia Truong (https://github.com/ttnghia) URL: #8125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8079
This PR:
concatenate_list_elementsin cython and plumbs it to our python API,.str.joinstr.join.