Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add todo
Browse files Browse the repository at this point in the history
galipremsagar committed Apr 28, 2021

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
1 parent 49e9248 commit 743981d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions python/cudf/cudf/core/column/string.py
Original file line number Diff line number Diff line change
@@ -599,6 +599,10 @@ def join(
else:
# If self._column is not a ListColumn, we will have to
# split each row by character and create a ListColumn out of it.

# TODO: Remove this workaround after the following
# feature request is resolved
# FEA: https://github.com/rapidsai/cudf/issues/8094
strings_column = self._split_by_character()

if is_scalar(sep):

0 comments on commit 743981d

Please sign in to comment.