Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor libcudf strings concatenate to use make_strings_children #7937

Merged
merged 9 commits into from
Apr 20, 2021

Conversation

davidwendt
Copy link
Contributor

Refactor combine.cu to split out join_strings() and enable concatenate() to use make_strings_children utility.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 12, 2021
@davidwendt davidwendt self-assigned this Apr 12, 2021
@github-actions github-actions bot added the CMake CMake build issue label Apr 12, 2021
@davidwendt
Copy link
Contributor Author

Reference #7929

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #7937 (106c070) into branch-0.20 (599f62d) will increase coverage by 0.41%.
The diff coverage is 92.73%.

❗ Current head 106c070 differs from pull request most recent head 0615000. Consider uploading reports for the commit 0615000 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7937      +/-   ##
===============================================
+ Coverage        82.30%   82.71%   +0.41%     
===============================================
  Files              101      103       +2     
  Lines            17053    17711     +658     
===============================================
+ Hits             14035    14650     +615     
- Misses            3018     3061      +43     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <ø> (-6.45%) ⬇️
python/cudf/cudf/utils/utils.py 83.25% <ø> (-1.81%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <78.57%> (-1.04%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <80.00%> (+0.19%) ⬆️
python/cudf/cudf/core/column/struct.py 96.29% <86.66%> (-3.71%) ⬇️
python/cudf/cudf/core/index.py 93.04% <88.09%> (+0.01%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <88.57%> (+0.43%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 91.11% <92.30%> (+0.48%) ⬆️
python/cudf/cudf/core/join/join.py 96.75% <93.75%> (+0.24%) ⬆️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a504d1...0615000. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 12, 2021
@davidwendt davidwendt marked this pull request as ready for review April 12, 2021 21:18
@davidwendt davidwendt requested review from a team as code owners April 12, 2021 21:18
@davidwendt davidwendt requested review from trxcllnt and harrism April 12, 2021 21:18
cpp/src/strings/combine/concatenate.cu Show resolved Hide resolved
cpp/src/strings/combine/concatenate.cu Show resolved Hide resolved
cpp/src/strings/combine/concatenate.cu Show resolved Hide resolved
cpp/src/strings/combine/concatenate.cu Show resolved Hide resolved
cpp/src/strings/combine/concatenate.cu Show resolved Hide resolved
cpp/src/strings/combine/join.cu Show resolved Hide resolved
cpp/src/strings/combine/join.cu Show resolved Hide resolved
cpp/src/strings/combine/join.cu Show resolved Hide resolved
cpp/src/strings/combine/join.cu Show resolved Hide resolved
cpp/src/strings/combine/concatenate.cu Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 68495f9 into rapidsai:branch-0.20 Apr 20, 2021
@davidwendt davidwendt deleted the refactor-combine branch April 20, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants