Skip to content

Commit

Permalink
Refactor libcudf strings concatenate to use make_strings_children (#7937
Browse files Browse the repository at this point in the history
)

Refactor combine.cu to split out `join_strings()` and enable `concatenate()` to use `make_strings_children` utility.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Jake Hemstad (https://github.com/jrhemstad)

URL: #7937
  • Loading branch information
davidwendt authored Apr 20, 2021
1 parent 3d212b3 commit 68495f9
Show file tree
Hide file tree
Showing 5 changed files with 443 additions and 481 deletions.
3 changes: 2 additions & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,8 @@ add_library(cudf
src/strings/case.cu
src/strings/char_types/char_cases.cu
src/strings/char_types/char_types.cu
src/strings/combine.cu
src/strings/combine/concatenate.cu
src/strings/combine/join.cu
src/strings/contains.cu
src/strings/convert/convert_booleans.cu
src/strings/convert/convert_datetime.cu
Expand Down
Loading

0 comments on commit 68495f9

Please sign in to comment.