Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitify direct-to-cubin compilation and caching. #7919

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 8, 2021

This changes jitify2 get_kernel invocations to pass an -arch=sm_. arg which causes jitify to compile and disk-cache direct-to-cubin, rather than caching ptx. This alleviates some compilation issues for specific (possibly unsupported) environments/configurations, but more importantly should provide faster launching from a cached kernel.

@cwharris cwharris requested a review from a team as a code owner April 8, 2021 17:53
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 8, 2021
@cwharris cwharris added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond Jitify non-breaking Non-breaking change labels Apr 8, 2021
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Verified that this change works.)

@kkraus14 kkraus14 added the bug Something isn't working label Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #7919 (c893ea7) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

❗ Current head c893ea7 differs from pull request most recent head 0c00c69. Consider uploading reports for the commit 0c00c69 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7919      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17701     +817     
===============================================
+ Hits             13822    14647     +825     
+ Misses            3062     3054       -8     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <0.00%> (-3.99%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f395b...0c00c69. Read the comment docs.

cpp/src/rolling/rolling_detail.cuh Show resolved Hide resolved
@cwharris
Copy link
Contributor Author

cwharris commented Apr 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a5d2407 into rapidsai:branch-0.19 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants