Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Explore Jitify v2 Support #7245

Closed
cwharris opened this issue Jan 28, 2021 · 6 comments
Closed

[FEA] Explore Jitify v2 Support #7245

cwharris opened this issue Jan 28, 2021 · 6 comments
Assignees
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@cwharris
Copy link
Contributor

https://github.com/NVIDIA/jitify/blob/jitify2/jitify2_user_guide.md

@cwharris cwharris added feature request New feature or request Needs Triage Need team to review and classify labels Jan 28, 2021
@cwharris cwharris self-assigned this Jan 28, 2021
@kkraus14 kkraus14 added CMake CMake build issue Jitify libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jan 28, 2021
@cwharris
Copy link
Contributor Author

cwharris commented Feb 2, 2021

cudatoolkit=11.2 is being published to conda-forge currently.

conda-forge/cudatoolkit-feedstock#46

@github-actions
Copy link

github-actions bot commented Mar 4, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@cwharris
Copy link
Contributor Author

cwharris commented Mar 9, 2021

Jitify v1 allows headers to be provided the form of a string formatted liike <header_name>\n<header_source>. Jitify v2 expects both the header name and source to be included as a string map. We'll need to separate out the header name and header source from the <header_name>\n<header_source> format string to populate the string map so jitify v2 will understand it.

This can be done by changing the existing jit'd header file sources to exclude the name, or by extracting it at runtime. The former option seems more straightforward.

@vyasr
Copy link
Contributor

vyasr commented Apr 6, 2021

@cwharris we can close this now that #7372 is merged, right?

@cwharris
Copy link
Contributor Author

cwharris commented Apr 7, 2021

@vyasr not yet, we're still looking in to some issues.

@cwharris
Copy link
Contributor Author

cwharris commented Apr 9, 2021

#7919

@cwharris cwharris closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

3 participants