Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning about non-POD types passed through ellipsis #7781

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Fix compiler warning about non-POD types passed through ellipsis #7781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51c7ead
See if unnamed variadic template parameter pack fixes the warning.
jrhemstad Mar 31, 2021
c7ed68c
Use actual variadic template.
jrhemstad Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cpp/include/cudf/detail/gather.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ void gather_helper(InputItr source_itr,
// Error case when no other overload or specialization is available
template <typename Element, typename Enable = void>
struct column_gatherer_impl {
std::unique_ptr<column> operator()(...) { CUDF_FAIL("Unsupported type in gather."); }
template <typename... Args>
std::unique_ptr<column> operator()(Args&&...)
{
CUDF_FAIL("Unsupported type in gather.");
}
};

/**
Expand Down
6 changes: 5 additions & 1 deletion cpp/include/cudf/detail/scatter.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,11 @@ auto scatter_to_gather(MapIterator scatter_map_begin,

template <typename Element, typename Enable = void>
struct column_scatterer_impl {
std::unique_ptr<column> operator()(...) const { CUDF_FAIL("Unsupported type for scatter."); }
template <typename... Args>
std::unique_ptr<column> operator()(Args&&...) const
{
CUDF_FAIL("Unsupported type for scatter.");
}
};

template <typename Element>
Expand Down
6 changes: 5 additions & 1 deletion cpp/src/copying/copy.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ namespace {

template <typename T, typename Enable = void>
struct copy_if_else_functor_impl {
std::unique_ptr<column> operator()(...) { CUDF_FAIL("Unsupported type for copy_if_else."); }
template <typename... Args>
std::unique_ptr<column> operator()(Args&&...)
{
CUDF_FAIL("Unsupported type for copy_if_else.");
}
};

template <typename T>
Expand Down