Fix compiler warning about non-POD types passed through ellipsis #7781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
added
bug
davidwendt
approved these changes
Mar 31, 2021
|
rerun tests |
1 similar comment
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7781 +/- ##
===============================================
+ Coverage 81.86% 82.67% +0.81%
===============================================
Files 101 103 +2
Lines 16884 17551 +667
===============================================
+ Hits 13822 14511 +689
+ Misses 3062 3040 -22
Continue to review full report at Codecov.
|
ttnghia
approved these changes
Apr 1, 2021
|
Rerun tests. |
harrism
approved these changes
Apr 1, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7725 I updated some of the fall through error cases to use old, C-style ellipsis variadics since we don't care about the parameters in the error case. Turns out C++ forbids passing "non-POD" types through this kind of variadic ellipsis, which ends up generating a compiler warning: